Improve warning message

Author: PedroM4rques

pandas/core/accessor.py

@@ -406,23 +406,29 @@ class AccessorEntryPointLoader:  # is this a good name for the class?
     @classmethod
     def load(cls) -> None:
         """loads and registers accessors defined by 'pandas_accessor'."""
-        packages = entry_points(group=cls.ENTRY_POINT_GROUP)
-        unique_packages_names: set[str] = set()
-
-        for package in packages:
-            # Verifies duplicated package names
-            if package.name in unique_packages_names:
+        accessors = entry_points(group=cls.ENTRY_POINT_GROUP)
+        unique_accessors_names: set[str] = set()
+
+        for accessor in accessors:
+            # Verifies duplicated accessor names
+            if accessor.name in unique_accessors_names:
+                try:
+                    pkg_name: str = accessor.dist.name
+                except Exception:
+                    pkg_name = "unknown"
                 warnings.warn(
-                    "Warning: you have two packages with the same name:"
-                    f" '{package.name}'\n"
-                    "Uninstall the package you don't want to use "
-                    "in order to remove this warning.\n",
+                    "Warning: you have two accessors with the same name:"
+                    f" '{accessor.name}' has already been registered"
+                    f" by the package '{pkg_name}'. So the '{accessor.name}' "
+                    f"provided by the package '{pkg_name}' is not "
+                    f"being used. Uninstall the package you don't want"
+                    "to use if you want to get rid of this warning.\n",
                     UserWarning,
                     stacklevel=2,
                 )
 
             else:
-                unique_packages_names.add(package.name)
+                unique_accessors_names.add(accessor.name)
 
             def make_property(ep):
                 def accessor(self) -> Any:
@@ -431,4 +437,5 @@ def accessor(self) -> Any:
 
                 return accessor
 
-            register_dataframe_accessor(package.name)(make_property(package))
+            # _register_accessor()
+            register_dataframe_accessor(accessor.name)(make_property(accessor))

pandas/tests/test_plugis_entrypoint_loader.py

@@ -2,6 +2,8 @@
 import pandas._testing as tm
 from pandas.core.accessor import AccessorEntryPointLoader
 
+# TODO: test for pkg names
+
 
 def test_no_accessors(monkeypatch):
     # GH29076
@@ -91,7 +93,7 @@ def mock_entry_points(*, group):
         AccessorEntryPointLoader.load()
 
     messages = [str(w.message) for w in record]
-    assert any("you have two packages with the same name:" in msg for msg in messages)
+    assert any("you have two accessors with the same name:" in msg for msg in messages)
 
     df = pd.DataFrame({"x": [1, 2, 3]})
     assert hasattr(df, "duplicate_accessor")
@@ -203,16 +205,16 @@ def mock_entry_points(*, group):
 
     messages = [str(w.message) for w in record]
 
-    # Filter warnings for the specific message about duplicate packages
+    # Filter warnings for the specific message about duplicate accessors
     duplicate_package_warnings = [
         msg
         for msg in messages
-        if "you have two packages with the same name: 'duplicate_accessor'" in msg
+        if "you have two accessors with the same name: 'duplicate_accessor'" in msg
     ]
 
-    # Assert one warning about duplicate packages
+    # Assert one warning about duplicate accessors
     assert len(duplicate_package_warnings) == 1, (
-        f"Expected exactly one warning about duplicate packages, "
+        f"Expected exactly one warning about duplicate accessors, "
         f"got {len(duplicate_package_warnings)}: {duplicate_package_warnings}"
     )