Refactor DataFrame and Series methods to improve attribute handling and finalize behavior

Author: fbourgey

pandas/core/frame.py

@@ -7875,19 +7875,13 @@ class      diet
     def _cmp_method(self, other, op):
         axis: Literal[1] = 1  # only relevant for Series other case
 
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            self.__finalize__(other)
-
         self, other = self._align_for_op(other, axis, flex=False, level=None)
 
         # See GH#4537 for discussion of scalar op behavior
         new_data = self._dispatch_frame_op(other, op, axis=axis)
         return self._construct_result(new_data, other=other)
 
     def _arith_method(self, other, op):
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            self.__finalize__(other)
-
         if self._should_reindex_frame_op(other, op, 1, None, None):
             return self._arith_method_with_reindex(other, op)
 
@@ -8107,6 +8101,9 @@ def _align_for_op(
         left : DataFrame
         right : Any
         """
+        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
+            self.__finalize__(other)
+
         left, right = self, other
 
         def to_series(right):

pandas/core/series.py

@@ -5938,7 +5938,7 @@ def _construct_result(
         self,
         result: ArrayLike | tuple[ArrayLike, ArrayLike],
         name: Hashable,
-        other=None,
+        other: AnyArrayLike | DataFrame | None = None,
     ) -> Series | tuple[Series, Series]:
         """
         Construct an appropriately-labelled Series from the result of an op.
@@ -5947,14 +5947,13 @@ def _construct_result(
         ----------
         result : ndarray or ExtensionArray
         name : Label
+        other : Series, DataFrame or array-like, default None
 
         Returns
         -------
         Series
             In the case of __divmod__ or __rdivmod__, a 2-tuple of Series.
         """
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            self.__finalize__(other)
         if isinstance(result, tuple):
             # produced by divmod or rdivmod
 
@@ -5975,6 +5974,8 @@ def _construct_result(
         # Set the result's name after __finalize__ is called because __finalize__
         #  would set it back to self.name
         out.name = name
+        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
+            out.__finalize__(other)
         return out
 
     def _flex_method(self, other, op, *, level=None, fill_value=None, axis: Axis = 0):