REF: Enhance _construct_result method to accept 'other' parameter for improved attribute handling

Author: fbourgey

pandas/core/base.py

@@ -1480,9 +1480,9 @@ def _arith_method(self, other, op):
         with np.errstate(all="ignore"):
             result = ops.arithmetic_op(lvalues, rvalues, op)
 
-        return self._construct_result(result, name=res_name)
+        return self._construct_result(result, name=res_name, other=other)
 
-    def _construct_result(self, result, name):
+    def _construct_result(self, result, name, other=None):
         """
         Construct an appropriately-wrapped result from the ArrayLike result
         of an arithmetic-like operation.

pandas/core/frame.py

@@ -7882,7 +7882,7 @@ def _cmp_method(self, other, op):
 
         # See GH#4537 for discussion of scalar op behavior
         new_data = self._dispatch_frame_op(other, op, axis=axis)
-        return self._construct_result(new_data)
+        return self._construct_result(new_data, other=other)
 
     def _arith_method(self, other, op):
         if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
@@ -7898,7 +7898,7 @@ def _arith_method(self, other, op):
 
         with np.errstate(all="ignore"):
             new_data = self._dispatch_frame_op(other, op, axis=axis)
-        return self._construct_result(new_data)
+        return self._construct_result(new_data, other=other)
 
     _logical_method = _arith_method
 
@@ -8275,12 +8275,9 @@ def _flex_arith_method(
 
                 new_data = self._dispatch_frame_op(other, op)
 
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            self.__finalize__(other)
+        return self._construct_result(new_data, other=other)
 
-        return self._construct_result(new_data)
-
-    def _construct_result(self, result) -> DataFrame:
+    def _construct_result(self, result, other=None) -> DataFrame:
         """
         Wrap the result of an arithmetic, comparison, or logical operation.
 
@@ -8292,6 +8289,8 @@ def _construct_result(self, result) -> DataFrame:
         -------
         DataFrame
         """
+        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
+            self.__finalize__(other)
         out = self._constructor(result, copy=False).__finalize__(self)
         # Pin columns instead of passing to constructor for compat with
         #  non-unique columns case
@@ -8316,11 +8315,8 @@ def _flex_cmp_method(self, other, op, *, axis: Axis = "columns", level=None):
 
         self, other = self._align_for_op(other, axis, flex=True, level=level)
 
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            self.__finalize__(other)
-
         new_data = self._dispatch_frame_op(other, op, axis=axis)
-        return self._construct_result(new_data)
+        return self._construct_result(new_data, other=other)
 
     @Appender(ops.make_flex_doc("eq", "dataframe"))
     def eq(self, other, axis: Axis = "columns", level=None) -> DataFrame:

pandas/core/indexes/base.py

@@ -7148,10 +7148,10 @@ def _logical_method(self, other, op):
         rvalues = extract_array(other, extract_numpy=True, extract_range=True)
 
         res_values = ops.logical_op(lvalues, rvalues, op)
-        return self._construct_result(res_values, name=res_name)
+        return self._construct_result(res_values, name=res_name, other=other)
 
     @final
-    def _construct_result(self, result, name):
+    def _construct_result(self, result, name, other=None):
         if isinstance(result, tuple):
             return (
                 Index(result[0], name=name, dtype=result[0].dtype),

pandas/core/series.py

@@ -5850,9 +5850,6 @@ def to_period(
     def _cmp_method(self, other, op):
         res_name = ops.get_op_result_name(self, other)
 
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            self.__finalize__(other)
-
         if isinstance(other, Series) and not self._indexed_same(other):
             raise ValueError("Can only compare identically-labeled Series objects")
 
@@ -5861,24 +5858,20 @@ def _cmp_method(self, other, op):
 
         res_values = ops.comparison_op(lvalues, rvalues, op)
 
-        return self._construct_result(res_values, name=res_name)
+        return self._construct_result(res_values, name=res_name, other=other)
 
     def _logical_method(self, other, op):
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            self.attrs = other.attrs
         res_name = ops.get_op_result_name(self, other)
         self, other = self._align_for_op(other, align_asobject=True)
 
         lvalues = self._values
         rvalues = extract_array(other, extract_numpy=True, extract_range=True)
 
         res_values = ops.logical_op(lvalues, rvalues, op)
-        return self._construct_result(res_values, name=res_name)
+        return self._construct_result(res_values, name=res_name, other=other)
 
     def _arith_method(self, other, op):
         self, other = self._align_for_op(other)
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            self.attrs = other.attrs
         return base.IndexOpsMixin._arith_method(self, other, op)
 
     def _align_for_op(self, right, align_asobject: bool = False):
@@ -5938,14 +5931,14 @@ def _binop(self, other: Series, func, level=None, fill_value=None) -> Series:
 
         name = ops.get_op_result_name(self, other)
 
-        if not getattr(this, "attrs", None) and getattr(other, "attrs", None):
-            this.__finalize__(other)
-
-        out = this._construct_result(result, name)
+        out = this._construct_result(result, name, other)
         return cast(Series, out)
 
     def _construct_result(
-        self, result: ArrayLike | tuple[ArrayLike, ArrayLike], name: Hashable
+        self,
+        result: ArrayLike | tuple[ArrayLike, ArrayLike],
+        name: Hashable,
+        other=None,
     ) -> Series | tuple[Series, Series]:
         """
         Construct an appropriately-labelled Series from the result of an op.
@@ -5960,11 +5953,13 @@ def _construct_result(
         Series
             In the case of __divmod__ or __rdivmod__, a 2-tuple of Series.
         """
+        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
+            self.__finalize__(other)
         if isinstance(result, tuple):
             # produced by divmod or rdivmod
 
-            res1 = self._construct_result(result[0], name=name)
-            res2 = self._construct_result(result[1], name=name)
+            res1 = self._construct_result(result[0], name=name, other=other)
+            res2 = self._construct_result(result[1], name=name, other=other)
 
             # GH#33427 assertions to keep mypy happy
             assert isinstance(res1, Series)