BUG: GH10209 fix bug where date_format in to_csv is sometimes ignored #10247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/source/whatsnew/v0.17.0.txt
Outdated
There was a problem hiding this comment.
use backticks around date_format
|
This might be a silly question: Would I need to rebase after the PR passed the build test but has become stale? |
|
you need to move the release note to v0.16.2.txt |
|
Ah. I see. Will do. Thanks! |
There was a problem hiding this comment.
data_format -> date_format
There was a problem hiding this comment.
Thanks for your eagle eye!
|
merged via 282746a thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10209
When datetimes are not dates only i.e. have fractional day values, date_format passed to to_csv is ignored.