Skip to content

Conversation

Winterflower
Copy link
Contributor

Fix for #11223
@TomAugspurger should these two Ipython blocks be merged into one?

(this is what it looks like at the mo)
pandas-11223

@TomAugspurger
Copy link
Contributor

That'd be fine, or maybe put a note before each saying something like "First some setup" and "with the setup out of the way...". Either way, it'll be an improvement 👍

@Winterflower
Copy link
Contributor Author

Added some 'verbal sugar' on either side of the Ipython directive blocks. Hope that's ok.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this s at the end of the previous block

@jorisvandenbossche jorisvandenbossche added this to the 0.17.1 milestone Oct 27, 2015
@jorisvandenbossche
Copy link
Member

Looks good!

I just put some comments, but that is actually more about the current content than your change :-)

@jorisvandenbossche
Copy link
Member

@Winterflower Do you have some time to update this?

@Winterflower
Copy link
Contributor Author

yep, @jorisvandenbossche will do tonight!

@jreback
Copy link
Contributor

jreback commented Nov 13, 2015

@Winterflower ping when pushed & green

DOC: Some minor additional fixes

Added some corrections
@Winterflower
Copy link
Contributor Author

@jreback pushed and green!

jreback added a commit that referenced this pull request Nov 14, 2015
DOC:Remove supression from ipython directive to make object visible
@jreback jreback merged commit 96c1f63 into pandas-dev:master Nov 14, 2015
@jreback
Copy link
Contributor

jreback commented Nov 14, 2015

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants