Skip to content

Conversation

chris-b1
Copy link
Contributor

@chris-b1 chris-b1 commented Dec 6, 2015

closes #11406 - makes QuarterBegin for n=0 match Month/Year.

xref #11427 - once this is merged the failures there should pass - there is also a little more documentation about general offset semantics in that PR.

@jreback jreback added Datetime Datetime data dtype Frequency DateOffsets labels Dec 7, 2015
@jreback jreback added this to the 0.18.0 milestone Dec 7, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the issue number reference here

@jreback
Copy link
Contributor

jreback commented Dec 7, 2015

cc @cancan101
cc @seth-p

look ok to you?

@seth-p
Copy link
Contributor

seth-p commented Dec 7, 2015

Looks fine to me, though I don't recall ever commenting on offsets.

On Dec 7, 2015, at 1:24 PM, Jeff Reback <[email protected]mailto:[email protected]> wrote:

cc @cancan101https://github.com/cancan101
cc @seth-phttps://github.com/seth-p

look ok to you?

Reply to this email directly or view it on GitHubhttps://github.com//pull/11777#issuecomment-162493690.

@rockg
Copy link
Contributor

rockg commented Dec 7, 2015

From #8435 does this now return something sensible?

pd.Timestamp('11/2/2012', tz='US/Eastern') + pd.tseries.offsets.QuarterBegin()
Out[29]: Timestamp('2012-12-01 00:00:00-0500', tz='US/Eastern')
pd.Timestamp('11/2/2012', tz='US/Eastern') + pd.tseries.offsets.QuarterEnd()
Out[30]: Timestamp('2012-12-31 00:00:00-0500', tz='US/Eastern')

@jreback
Copy link
Contributor

jreback commented Dec 7, 2015

cc @MichaelWS

@MichaelWS
Copy link
Contributor

Looks sensible to me

@jreback
Copy link
Contributor

jreback commented Dec 9, 2015

@rockg I believe that @chris-b1 next PR, #11370 wiill address that (and is dependent on this PR)

@jreback
Copy link
Contributor

jreback commented Dec 10, 2015

merged via 56fd4e3

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Datetime Datetime data dtype Frequency DateOffsets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: QuarterBegin doesn't match other offsets for n=0

5 participants