Hdffixes #12248
Closed
Hdffixes #12248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
these changes are separate the iterable a ones don't have tests |
|
Yes, they are separate: do you prefer separate PRs? The iterable one has test at line 394 of |
|
separate the iterator one needs to inherit from BaseIterator |
|
OK, now repushing them separately. But BaseIterator is not a meaningful ancestor for HDFStore itself, since the latter can be iterated more than once, i.e. doesn't have state (i.e. doesn't have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12221 and #10381 . Same source file, but let me know if you want separate PRs.