Skip to content

Conversation

dacoex
Copy link
Contributor

@dacoex dacoex commented Feb 10, 2016

In accordance with #12268 this is now a separate PR.

I think that this warning could be useful either way for no non-daily hdf user:

  • Telling that string method is preferred
  • Adding a warning

@jreback
Copy link
Contributor

jreback commented Feb 10, 2016

@dacoex idea being that you separate the changes into 2 PRs, one containing the pd. changes, the other the doc-changes w.r.t. hierarchical keys. (there are 2 PR's now, but they both contain all the changes)

@jreback jreback added Docs IO HDF5 read_hdf, HDFStore labels Feb 10, 2016
@dacoex
Copy link
Contributor Author

dacoex commented Feb 10, 2016

Sorry, my git skills do not make it.
I will update them during the next days.

@jreback
Copy link
Contributor

jreback commented Feb 10, 2016

hahha, no prob. you will want to rebase on master, then delete that commit.

e.g.

git rebase -i master

then force push

@jreback
Copy link
Contributor

jreback commented Mar 12, 2016

pls rebase on master

@dacoex
Copy link
Contributor Author

dacoex commented Mar 13, 2016

I hope I got it right now ;-)

@dacoex
Copy link
Contributor Author

dacoex commented Apr 23, 2016

anything holding this one back?

@jreback jreback added this to the 0.18.1 milestone Apr 23, 2016
@jreback jreback closed this in 92b5322 Apr 23, 2016
@jreback
Copy link
Contributor

jreback commented Apr 23, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs IO HDF5 read_hdf, HDFStore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants