BUG: GH12622 where pprint of Timestamp in nested structure fails

[kawochen]

• closes BUG: pandas.Timestamp misbehaves in deeply nested pprint on Python 3 #12622
• tests added / passed
• passes git diff upstream/master | flake8 --diff
• whatsnew entry

I suspect this is a bug in Cython (I don't think type(A).func should be an instancemethod). Not sure if we should use this workaround as we encounter issues in the wild, or do this for all the functions we can think of.

[jreback]

so moving this to _Timestamp worked, interesting. Should move any referenced functions as well ,e.g. ._repr_base. _date_repr & _time_repr for consistency.

[kawochen]

updated

[jreback]

@wesm this work for you?

[jreback]

@kawochen let's put a test in for Timedelta. I think it has the same issue.

[wesm]

Looks like this should work. Cython esoterica!

[jreback]

thanks @kawochen

[jreback]

@kawochen forgot to test for Timedelta, can you do a pr which adds?

Though does seem to work

In [7]: d = {'foo': 1, 'bar': [{'what': {'footttttttttttttttttttttttttttttttttt': pd.Timestamp('2011-01-01')}}] * 10, 'baz': [{'what': {'footttttttttttttttttttttttttttttttttt': pd.Timedelta('1 day 1 min')}}] * 10} 
In [8]: d
Out[8]: 
{'bar': [{'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}}],
 'baz': [{'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
  {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}}],
 'foo': 1}

In [9]: pprint.pprint(d)
{'bar': [{'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timestamp('2011-01-01 00:00:00')}}],
 'baz': [{'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}},
         {'what': {'footttttttttttttttttttttttttttttttttt': Timedelta('1 days 00:01:00')}}],
 'foo': 1}

[kawochen]

No problem. Was going to update today :)