Skip to content

COMPAT: feather-format 0.4.0 compat #16475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2017
Merged

COMPAT: feather-format 0.4.0 compat #16475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/requirements-3.5_OSX.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ source activate pandas

echo "install 35_OSX"

conda install -n pandas -c conda-forge feather-format
conda install -n pandas -c conda-forge feather-format==0.3.1
17 changes: 13 additions & 4 deletions pandas/tests/io/test_feather.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
from feather import FeatherError
from pandas.util.testing import assert_frame_equal, ensure_clean
import pandas.util.testing as tm
from distutils.version import LooseVersion


fv = LooseVersion(feather.__version__)


@pytest.mark.single
Expand Down Expand Up @@ -57,6 +61,7 @@ def test_basic(self):
assert df.dttz.dtype.tz.zone == 'US/Eastern'
self.check_round_trip(df)

@pytest.mark.skipif(fv >= '0.4.0', reason='fixed in 0.4.0')
def test_strided_data_issues(self):

# strided data issuehttps://github.com/wesm/feather/issues/97
Expand All @@ -76,19 +81,23 @@ def test_stringify_columns(self):
df = pd.DataFrame(np.arange(12).reshape(4, 3)).copy()
self.check_error_on_write(df, ValueError)

@pytest.mark.skipif(fv >= '0.4.0', reason='fixed in 0.4.0')
def test_unsupported(self):

# period
df = pd.DataFrame({'a': pd.period_range('2013', freq='M', periods=3)})
self.check_error_on_write(df, ValueError)

# timedelta
df = pd.DataFrame({'a': pd.timedelta_range('1 day', periods=3)})
self.check_error_on_write(df, FeatherError)

# non-strings
df = pd.DataFrame({'a': ['a', 1, 2.0]})
self.check_error_on_write(df, ValueError)

def test_unsupported_other(self):

# period
df = pd.DataFrame({'a': pd.period_range('2013', freq='M', periods=3)})
self.check_error_on_write(df, ValueError)

def test_write_with_index(self):

df = pd.DataFrame({'A': [1, 2, 3]})
Expand Down