TST: Remove pow test in expressions #18995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are already skipped for NumPy>=1.12, and buggy for NumPy 1.10.4
TomAugspurger
added
Needs Backport
Testing
|
great. you need this with newest conda though. |
|
I added a commit to fix conda |
This was referenced Dec 29, 2017
Closed
|
I don't think we need to backport the conda fix though. This should have passed on master (without testing 1.10.0), and when I add it to the backport PR it will be tested. |
|
right my point is if it DOES pass on master that will fix it. But it IS not tested on master currently. So I would merge this on master and just cherry-pick your 1 commit in the backport. (your 1 commit won't fail on master because of the pinned conda version) |
|
Sounds good. |
|
@TomAugspurger this looks good to merge & backport (the 1 commit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are already skipped for NumPy>=1.12, and buggy for NumPy
1.10.4
cc @jreback
This will be backported.
closes #18992