Skip to content

Conversation

alysivji
Copy link
Contributor

@alysivji alysivji commented Jan 5, 2018

Continuation of #18931

  • Converted class-based setup fixtures to pytest fixtures
  • Consolidated all imports at the top of the file

test_aggregate_item_by_item has an unused DataFrame in the test so cleaned that up as well

Please let me know if you need me to make any changes.

@jreback jreback added Groupby Testing pandas testing functions or related to the test suite labels Jan 5, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 5, 2018
@jreback
Copy link
Contributor

jreback commented Jan 5, 2018

lgtm. ping on green.

@codecov
Copy link

codecov bot commented Jan 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@856c92b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #19094   +/-   ##
=========================================
  Coverage          ?   91.53%           
=========================================
  Files             ?      148           
  Lines             ?    48688           
  Branches          ?        0           
=========================================
  Hits              ?    44567           
  Misses            ?     4121           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.9% <ø> (?)
#single 41.63% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856c92b...f46b2bd. Read the comment docs.

@alysivji
Copy link
Contributor Author

alysivji commented Jan 5, 2018

@jreback we are green!

@jreback jreback merged commit e1888f0 into pandas-dev:master Jan 5, 2018
@jreback
Copy link
Contributor

jreback commented Jan 5, 2018

thanks @alysivji nice PR!

@alysivji alysivji deleted the finish_agg_cleanup branch January 5, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Groupby Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants