Clean up the C code #1925
Closed
Clean up the C code #1925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent GCC -Wall warning.
Replaced by a static const array in a C module. Prevents warnings and potential multiple inclusion hazards. Also, added a const qualifier to another static array.
Unused function in np_datetime_strings.c commented out since it was referenced from some commented-out source code.
|
This is great, thanks so much (merged/rebased these commits) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some patches to make
python setup.py buildproduce less noise. Compiled with GCC 4.6.3 and Clang 3.0; all tests pass.