always use UnicodeWriter for csv, default to utf-8 #2006
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe closes #1966 If the input is NOT pure ascii and no encoding is specified, the python stdlib csv module will die. if the input IS pure ascii, then using UnicodeWriter with utf-8 as encoding will produce the same end result as a pure ascii writer. This change will "just work" for more cases. also, presumably, internal representations of all text in pandas will eventually be unicode, so this meshes with that program too. there might be a performance issue for large files (is the python csv native?). If so, I think this still the way to go with the stdlib csv module becoming the optional path. a lot of issues have touched on csv and unicode, see #206,#300,#680,#705,#1966, probably more
|
should be ok now. The patch dovetails with the series in #2005. |
ghost
mentioned this pull request
|
withdrawn. bad idea. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see long commit message for the rational.