Skip to content

TST: tests for inconsistent indexing with datetimes #20550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2018
Merged

TST: tests for inconsistent indexing with datetimes #20550

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36528d5
TST: test added to GH9336
jcontesti Mar 30, 2018
c28394a
TST: code moved to test_indexing
jcontesti May 6, 2018
c1dfe56
TST: rest of the examples in #9336 added to new testing method
jcontesti May 20, 2018
63350d3
TST: df declaration improved, numpy array assignation is now done wit…
jcontesti May 26, 2018
f7fb642
TST: datetime objects in numpy array are now directly numpy datetime …
jcontesti May 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions pandas/tests/frame/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,6 +1548,25 @@ def test_setitem_single_column_mixed_datetime(self):
# pytest.raises(
# Exception, df.loc.__setitem__, ('d', 'timestamp'), [nan])

def test_setitem_mixed_datetime(self):
# GH 9336
expected = DataFrame({'a': [0, 0, 0, 0, 13, 14],
'b': [pd.datetime(2012, 1, 1),
1,
'x',
'y',
pd.datetime(2013, 1, 1),
pd.datetime(2014, 1, 1)]})
df = pd.DataFrame(np.zeros((6, 2), dtype=int), columns=['a', 'b'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is failing because you are specify the dtype directly I think, just use
pd.DataFrame(0, columns = list('ab'), index=range(6))

df['b'] = pd.NaT
df.loc[0, 'b'] = pd.datetime(2012, 1, 1)
df.loc[1, 'b'] = 1
df.loc[[2, 3], 'b'] = 'x', 'y'
A = pd.DataFrame([[13, pd.datetime(2013, 1, 1)],
[14, pd.datetime(2014, 1, 1)]])
df.loc[[4, 5], ['a', 'b']] = A.values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you assign with a numpy array that you construct directly

assert_frame_equal(df, expected)

def test_setitem_frame(self):
piece = self.frame.loc[self.frame.index[:2], ['A', 'B']]
self.frame.loc[self.frame.index[-2]:, ['A', 'B']] = piece.values
Expand Down