-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
BUG: Should not raise error in concatenating Series with numpy scalar and tuple names (GH21015) #21132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
BUG: Should not raise error in concatenating Series with numpy scalar and tuple names (GH21015) #21132
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
13f00df
GH21015
KalyanGokhale 354eb2d
GH21015
KalyanGokhale 613ab4e
GH21015
KalyanGokhale 3e84f9c
GH21015
KalyanGokhale 35b664f
GH21015
KalyanGokhale 7ec0135
GH21015
KalyanGokhale 345c084
GH21015
KalyanGokhale 21d834e
GH21015
KalyanGokhale ba8abba
GH21015
KalyanGokhale 8aa7e05
GH21015
KalyanGokhale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2487,3 +2487,14 @@ def test_concat_aligned_sort_does_not_raise(): | |
columns=[1, 'a']) | ||
result = pd.concat([df, df], ignore_index=True, sort=True) | ||
tm.assert_frame_equal(result, expected) | ||
|
||
|
||
@pytest.mark.parametrize("s1name,s2name", [ | ||
(np.int64(190), (43, 0)), (190, (43, 0))]) | ||
|
||
def test_concat_series_name_npscalar_tuple(s1name, s2name): | ||
# GH21015 | ||
s1 = pd.Series({'a': 1, 'b': 2}, name=s1name) | ||
s2 = pd.Series({'c': 5, 'd': 6}, name=s2name) | ||
result = pd.concat([s1, s2]) | ||
expected = pd.Series({'a': 1, 'b': 2, 'c': 5, 'd': 6}) | ||
tm.assert_series_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's replace ``Series`` with :class:`Series`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done