Skip to content

Conversation

khughitt
Copy link
Contributor

Sometimes the random colors chosen in parallel_plot are very unfortunate, so I thought it would be nice to provide an option to pass a list of colors in.

@changhiskhan
Copy link
Contributor

Looks good to me. Can you please add a test case so I can merge it in? Thanks!

@khughitt
Copy link
Contributor Author

Sure thing. How does this look?

I have one more related pull request I was planning on submitting after this which enables the x-axis to be rescaled when numeric column values are used (e.g. "# hours"). Is there anywhere I should go first to suggest the change, or is it okay to just submit another pull request?

Thanks!

@changhiskhan
Copy link
Contributor

If you already coded it up, feel free to make another PR. What's the current behavior that's not right?

@changhiskhan
Copy link
Contributor

Cherry-picked. Thanks very much!

@khughitt
Copy link
Contributor Author

Great! Currently parallel plots remaps the x values to 0, 1, 2, 3... so the plot is also scaled linearly. It wasn't too hard to change it so that if all of the columns are numeric it uses those as the xticks. This way when you pass it something with columns that are not evenly-spaced the plot is scaled correctly.

I'll go ahead and submit a pull request.

@changhiskhan
Copy link
Contributor

Oh I see, that makes sense. Maybe make that an option instead of doing it automatically? Like a 'use_columns' parameter analogous to 'use_index'.
Also maybe another optional parameter to pass in an external set of xticks so if you already have meaningful column names, you don't have to mangle them to get the spacing right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants