Fixes for #1000, to_string(), to_html() should respect col_space #2328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, breakage. |
added 5 commits
November 22, 2012 20:20
wasn't implemented till now, so shouldn't break anything. colSpace was already deprecated in favor of col_space, so I would feel bad about deprecating col_space in favor of min_col_width.
|
Travis is experiencing weirdness with numpy on py3, tox runs clean for me on 3.2. |
|
Yeah what's going on with that? hopefully transient |
|
Merged this, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the semantics of
col_spaceare different in each case, characters vs. pixels,but that's reasonable.
I hope this doesn't presage more html configuration via kwd arguments, yonder way
madness lies.
also, there's a discrepency between the docstring and io.rst (github doesn't seem to jump to the right line)
the first defines it as the width of the columns, the latter as the number of spaces between columns,
I adopted the former, since space between columns does not translate as easily to html.
sigh, also,
colSpacehas already been deprecated in favor ofcol_space, soI would feel bad about deprecating
col_spacein favor ofmin_col_width.I'll leave that decision to braver, fearless souls.
closes #1000.