Support for datetime columns with rpy2 #2352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. I left those out when I wrote support for conversions mainly because I did not use any of the datetime features (on R and Python). As one who wrote the code, you get a +1 from me. |
Check to see if the values we're looking at are numpy datetime64 objects. If they are, we can assume we're looking at a Timestamp object, which subclasses Python's datetime class, and we return a struct_time which is understood by rpy2's POSIXct class.
|
Cherry-picked this commit. It'd be great to see some tests for this at some point (separate PR is fine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check to see if the values we're looking at are numpy datetime64
objects. If they are, we can assume we're looking at a Timestamp object,
which subclasses Python's datetime class, and we return a struct_time
which is understood by rpy2's POSIXct class.
Attempt at a fix for #2351