BUG: create correctly named indexables in HDFStore Tables #2481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indexable columns were created and named in a legacy format, now named like the indexable in the object, e.g. 'index' for DataFrame, or 'major_axis'/'minor_axis' for Panel fixes an issue if we want to support say a 'column' oriented Table (e.g. instead of storing the transpose, store with a 'column' indexables) - not implemented yet, but supported now
|
Cool, cherry-picking now |
|
cool....btw...i potentially have 1 more pr for pytables....adding support for Panel4D....when are you going to freeze for release? |
|
I think we can slip it in anytime this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexable in the object, e.g. 'index' for DataFrame, or 'major_axis'/'minor_axis' for Panel
(e.g. instead of storing the transpose,
store with a 'column' indexables) - not implemented yet, but supported now