Fixes Formatting Exception

doc/source/whatsnew/v0.24.2.rst

@@ -51,7 +51,7 @@ Bug Fixes
 
 **I/O**
 
--
+- Better handling of terminal printing when the terminal dimensions are not known (#25080);
 -
 -
 
@@ -96,4 +96,4 @@ Bug Fixes
 Contributors
 ~~~~~~~~~~~~
 
-.. contributors:: v0.24.1..v0.24.2
+.. contributors:: v0.24.1..v0.24.2

pandas/io/formats/terminal.py

@@ -15,6 +15,7 @@
 
 import os
 import shutil
+import subprocess
 
 from pandas.compat import PY3
 
@@ -94,22 +95,29 @@ def _get_terminal_size_tput():
     # get terminal width
     # src: http://stackoverflow.com/questions/263890/how-do-i-find-the-width
     # -height-of-a-terminal-window
+
     try:
-        import subprocess
         proc = subprocess.Popen(["tput", "cols"],
                                 stdin=subprocess.PIPE,
                                 stdout=subprocess.PIPE)
-        output = proc.communicate(input=None)
-        cols = int(output[0])
+        output_cols = proc.communicate(input=None)
         proc = subprocess.Popen(["tput", "lines"],
                                 stdin=subprocess.PIPE,
                                 stdout=subprocess.PIPE)
-        output = proc.communicate(input=None)
-        rows = int(output[0])
-        return (cols, rows)
+        output_rows = proc.communicate(input=None)
     except OSError:
         return None
 
+    try:
+        # Some terminals (e.g. spyder) may report a terminal size of '',
+        # making the `int` fail.
+
+        cols = int(output_cols[0])
+        rows = int(output_rows[0])
+        return cols, rows
+    except (ValueError, IndexError):
+        return None
+
 
 def _get_terminal_size_linux():
     def ioctl_GWINSZ(fd):

pandas/tests/io/formats/test_console.py

@@ -1,6 +1,9 @@
+import subprocess
+
 import pytest
 
 from pandas.io.formats.console import detect_console_encoding
+from pandas.io.formats.terminal import _get_terminal_size_tput
 
 
 class MockEncoding(object):  # TODO(py27): replace with mock
@@ -72,3 +75,17 @@ def test_detect_console_encoding_fallback_to_default(monkeypatch, std, locale):
         context.setattr('sys.stdout', MockEncoding(std))
         context.setattr('sys.getdefaultencoding', lambda: 'sysDefaultEncoding')
         assert detect_console_encoding() == 'sysDefaultEncoding'
+
+
+@pytest.mark.parametrize("size", ['', ['']])
+def test_terminal_unknown_dimensions(size):
+    mock = pytest.importorskip("unittest.mock")
+
+    def communicate(*args, **kwargs):
+        return size
+
+    with mock.patch.object(subprocess.Popen, "communicate",
+                           side_effect=communicate):
+        result = _get_terminal_size_tput()
+
+    assert result is None