Try to fix BUG #2599 #2635
Closed
Try to fix BUG #2599 #2635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure this is a Cython bug also and should be reported separately |
|
Agreed, i will file something with them. However, I find it appealing to rely on numpy to provide the min and max values for the different dtypes rather than having to rely on stdint.h. I think i should be able to eliminate the use of any of the stdint stuff from parser.pyx. Would that be helpful or would you rather scrap the change altogether? |
|
Merged and verified this fixes the issue. Thanks dieter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is a good way to go about it, but it seems to work.
Might be good to get rid of all the INT64_MAX/MIN stuff in parser.pyx and replace with np.iinfo(np.int64).max/min instead.