Skip to content

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jan 24, 2013

arguments are inconsistent to numpy and Series.clip

@ghost
Copy link

ghost commented Feb 8, 2013

This obviously breaks back compat.
Maybe cheat and just use min(upper,lower) and max(upper,lower)?
That way both the old code and the numpy convention will work.

@jreback
Copy link
Contributor Author

jreback commented Feb 8, 2013

I think this SHOULD break compat, as it very self-inconsistent....how about a warning with the max/min as the test?

@ghost
Copy link

ghost commented Feb 8, 2013

Change the args around, but use min/max anyway. fix it and keep old code working.

@jreback
Copy link
Contributor Author

jreback commented Feb 8, 2013

fixed

@ghost
Copy link

ghost commented Feb 8, 2013

Changed to 0.10.2, now that it's not a breaking change.

@wesm
Copy link
Member

wesm commented Feb 8, 2013

Thank you guys

wesm added a commit that referenced this pull request Feb 10, 2013
@wesm wesm merged commit 8b77ace into pandas-dev:master Feb 10, 2013
@wesm
Copy link
Member

wesm commented Feb 10, 2013

Merged. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants