Series.rename now handles values by Series constructor #27975
Closed
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajvalgupta
changed the title
|
It looks like this PR changes 4 files, only one of which is related to the referenced issue. am i misunderstanding? can you include a test for the changed/fixed behavior |
|
The change for this PR is only in the pandas/core/series.py. I don't know why every other commit got included in it when it was from separate feature branch. Can you suggest what needs to be done? |
|
you can revert the changes to unrelated files with |
|
We also have #27814 for this. |
|
Looks like this was superseded by #27814 - thanks for the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff