Skip to content

COMPAT: implement visit_Constant for 3.8 compat #28101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 26, 2019
Merged

COMPAT: implement visit_Constant for 3.8 compat #28101

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d556e6b
COMPAT: implement visit_Constant for 3.8 compat
TomAugspurger Aug 22, 2019
ae495a6
coverage for odd cases
TomAugspurger Aug 23, 2019
a58f7e6
COMPAT: 3.8 compat for new datetime methods
TomAugspurger Aug 23, 2019
a61994b
COMPAT: 3.8 compat for parsers
TomAugspurger Aug 23, 2019
55800f2
COMPAT: 3.8 compat for expr
TomAugspurger Aug 23, 2019
793d978
Merge remote-tracking branch 'upstream/master' into 3.8-visit-constant
TomAugspurger Aug 23, 2019
07d723c
update docs
TomAugspurger Aug 23, 2019
3482be3
workaround
TomAugspurger Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ ExtensionArray
Other
^^^^^
- Trying to set the ``display.precision``, ``display.max_rows`` or ``display.max_columns`` using :meth:`set_option` to anything but a ``None`` or a positive int will raise a ``ValueError`` (:issue:`23348`)
- Compatibility with Python 3.8 in :meth:`DataFrame.query` (:issue:`27261`)


.. _whatsnew_1000.contributors:
Expand Down
3 changes: 3 additions & 0 deletions pandas/core/computation/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,9 @@ def visit_NameConstant(self, node, **kwargs):
def visit_Num(self, node, **kwargs):
return self.const_type(node.n, self.env)

def visit_Constant(self, node, **kwargs):
return self.const_type(node.n, self.env)

def visit_Str(self, node, **kwargs):
name = self.env.add_tmp(node.s)
return self.term_type(name, self.env)
Expand Down