Skip to content

Check for pyarrow not feather before pyarrow tests #31144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 24, 2020
Merged

Check for pyarrow not feather before pyarrow tests #31144

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d9364b
TST: Check for pyarrow before pyarrow.feather tests
rebecca-palmer Jan 19, 2020
b939900
TST: when checking for a nonexistent file error, accept pyarrow's err…
rebecca-palmer Jan 19, 2020
196e865
TST: check for IOError from pyarrow and not for quotes, linting
rebecca-palmer Jan 20, 2020
d8f7664
more linting
rebecca-palmer Jan 20, 2020
938bc4a
linting
rebecca-palmer Jan 21, 2020
788f92b
TST: accept other versions of pyarrow error message
rebecca-palmer Jan 21, 2020
c6ca500
linting
rebecca-palmer Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions pandas/tests/io/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def test_iterator(self):
(pd.read_csv, "os", FileNotFoundError, "csv"),
(pd.read_fwf, "os", FileNotFoundError, "txt"),
(pd.read_excel, "xlrd", FileNotFoundError, "xlsx"),
(pd.read_feather, "feather", Exception, "feather"),
(pd.read_feather, "pyarrow", IOError, "feather"),
(pd.read_hdf, "tables", FileNotFoundError, "h5"),
(pd.read_stata, "os", FileNotFoundError, "dta"),
(pd.read_sas, "os", FileNotFoundError, "sas7bdat"),
Expand All @@ -153,8 +153,11 @@ def test_read_non_existant(self, reader, module, error_class, fn_ext):
msg7 = (
fr"\[Errno 2\] File o directory non esistente: '.+does_not_exist\.{fn_ext}'"
)
msg8 = fr"Failed to open local file.+does_not_exist\.{fn_ext}.?, error: .*"

with pytest.raises(
error_class, match=fr"({msg1}|{msg2}|{msg3}|{msg4}|{msg5}|{msg6}|{msg7})"
error_class,
match=fr"({msg1}|{msg2}|{msg3}|{msg4}|{msg5}|{msg6}|{msg7}|{msg8})",
):
reader(path)

Expand All @@ -165,7 +168,7 @@ def test_read_non_existant(self, reader, module, error_class, fn_ext):
(pd.read_table, "os", FileNotFoundError, "csv"),
(pd.read_fwf, "os", FileNotFoundError, "txt"),
(pd.read_excel, "xlrd", FileNotFoundError, "xlsx"),
(pd.read_feather, "feather", Exception, "feather"),
(pd.read_feather, "pyarrow", IOError, "feather"),
(pd.read_hdf, "tables", FileNotFoundError, "h5"),
(pd.read_stata, "os", FileNotFoundError, "dta"),
(pd.read_sas, "os", FileNotFoundError, "sas7bdat"),
Expand Down Expand Up @@ -193,9 +196,11 @@ def test_read_expands_user_home_dir(
msg7 = (
fr"\[Errno 2\] File o directory non esistente: '.+does_not_exist\.{fn_ext}'"
)
msg8 = fr"Failed to open local file.+does_not_exist\.{fn_ext}.?, error: .*"

with pytest.raises(
error_class, match=fr"({msg1}|{msg2}|{msg3}|{msg4}|{msg5}|{msg6}|{msg7})"
error_class,
match=fr"({msg1}|{msg2}|{msg3}|{msg4}|{msg5}|{msg6}|{msg7}|{msg8})",
):
reader(path)

Expand All @@ -212,7 +217,7 @@ def test_read_expands_user_home_dir(
(pd.read_excel, "xlrd", ("io", "data", "excel", "test1.xlsx")),
(
pd.read_feather,
"feather",
"pyarrow",
("io", "data", "feather", "feather-0_3_1.feather"),
),
(
Expand Down Expand Up @@ -249,7 +254,7 @@ def test_read_fspath_all(self, reader, module, path, datapath):
[
("to_csv", {}, "os"),
("to_excel", {"engine": "xlwt"}, "xlwt"),
("to_feather", {}, "feather"),
("to_feather", {}, "pyarrow"),
("to_html", {}, "os"),
("to_json", {}, "os"),
("to_latex", {}, "os"),
Expand Down