BLD: recursive inclusion of DLLs in package data

[chris-b1]

• step 1 towards ImportError: DLL load failed with Windows wheel for 1.0.2 and 1.0.3 #32857

Will also make a PR in https://github.com/MacPython/pandas-wheels to add the DLLs to the wheel packaging script

[WillAyd]

Should we explicitly include the files we want? Just wondering if there's any licensing risk to recursively bundling dlls

[chris-b1]

Fair question - whole thing is a bit clunky - we will still specify the specific files in wheel building script, so no risk for now.
https://github.com/MacPython/pandas-wheels/pull/82/files#diff-c57957756c5cc094d7bb705d01a62868R74

[jreback]

• step 1 towards ImportError: DLL load failed with Windows wheel for 1.0.2 and 1.0.3 #32857

Will also make a PR in https://github.com/MacPython/pandas-wheels to add the DLLs to the wheel packaging script

I believe we are using azure to build and NOT the original MacPython repo.

[jreback]

Should we explicitly include the files we want? Just wondering if there's any licensing risk to recursively bundling dlls

NO, this is much easier.

[jreback]

@chris-b1 can you add a bug fix note in Other section (for 1.1). whether we backport is a different issue (we might not be doing a 1.0.4)

[TomAugspurger]

I believe we are using azure to build and NOT the original MacPython repo.

The azure stuff is running in the same MacPython repo.

[jreback]

I believe we are using azure to build and NOT the original MacPython repo.

The azure stuff is running in the same MacPython repo.

oh my mistake, I thought we were now generating wheels on the pandas runs? guess not

[TomAugspurger]

CI is passing here. Is this good to go?

[chris-b1]

Should be - still some path stuff to figure out on the wheel building PR that I haven't had a chance to look at, but in setup.py this is all that's needed

…

On Wed, Apr 8, 2020 at 12:58 PM Tom Augspurger ***@***.***> wrote: CI is passing here. Is this good to go? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33246 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOVX7F2I26VDIB7N5WAM73RLS3NHANCNFSM4L23PNQQ> .

[jreback]

we might need a what's new (esp if we backport to 1.0.4), can you do a followon (stick in 1.1 for now).

[simonjayhawkins]

@meeseeksdev backport to 1.0.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 1.0.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 aa8e869d76878f07dff065f947c99b5663342087

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #33246: BLD: recursive inclusion of DLLs in package data'

4. Push to a named branch :

git push YOURFORK 1.0.x:auto-backport-of-pr-33246-on-1.0.x

5. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #33246 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.