Skip to content

TST: Add Categorical Series test #33525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2020
+8 −0
Merged

TST: Add Categorical Series test #33525

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
998da40
TST: Add Categorical Series test
dsaxton Apr 13, 2020
2ad7888
Merge remote-tracking branch 'upstream/master' into cat-tests
dsaxton Apr 17, 2020
939843c
Test
dsaxton Apr 17, 2020
cc2c9e0
Revert "TST: Add Categorical Series test"
dsaxton Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/tests/reductions/test_reductions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,6 +1098,14 @@ def test_min_max_ordered(self, values, categories, function):
expected = categories[0] if function == "min" else categories[2]
assert result == expected

@pytest.mark.parametrize("function", ["min", "max"])
@pytest.mark.parametrize("skipna", [True, False])
def test_min_max_ordered_with_nan_only(self, function, skipna):
# https://github.com/pandas-dev/pandas/issues/33450
cat = Series(Categorical([np.nan], categories=[1, 2], ordered=True))
result = getattr(cat, function)(skipna=skipna)
assert result is np.nan

@pytest.mark.parametrize("function", ["min", "max"])
@pytest.mark.parametrize("skipna", [True, False])
def test_min_max_skipna(self, function, skipna):
Expand Down