Skip to content

BUG: Use args and kwargs in Rolling.apply #33983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 15, 2020
Merged

BUG: Use args and kwargs in Rolling.apply #33983

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ebea448
BUG: Use kwargs in apply in window
mproszewska May 4, 2020
e2b0f56
Run black
mproszewska May 5, 2020
1c279bb
Change unwanted pattern
mproszewska May 5, 2020
6c43f61
Include args and modify test
mproszewska May 10, 2020
f3b2c17
Add whatsnew note and test without groupby
mproszewska May 10, 2020
d1226a5
Merge branch 'master' into bug-kwargs
mproszewska May 15, 2020
f112b7c
Add requested changes
mproszewska May 15, 2020
cbd5aa9
Resolve conflict
mproszewska May 15, 2020
4a1e81a
Resolve conflict
mproszewska May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pandas/core/window/rolling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,6 +1300,7 @@ def apply(
use_numba_cache=engine == "numba",
raw=raw,
original_func=func,
kwargs=kwargs,
)

def _generate_cython_apply_func(self, args, kwargs, raw, offset, func):
Expand Down
10 changes: 10 additions & 0 deletions pandas/tests/window/test_apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,13 @@ def test_invalid_kwargs_nopython():
Series(range(1)).rolling(1).apply(
lambda x: x, kwargs={"a": 1}, engine="numba", raw=True
)


def test_apply_kwargs():
def foo(x, par):
return np.sum(x + par)

df = DataFrame({"gr": [1, 1], "a": [1, 2]})
result = df.groupby("gr")["a"].rolling(1).apply(foo, kwargs={"par": 10})
expected = np.array([11.0, 12.0])
tm.assert_numpy_array_equal(result.values, expected)