ENH: Set index of returned dataframe in DatetimeIndex.isocalendar #34392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
May 26, 2020
|
@jreback, thanks, what's new entry updated. Back to green. |
jreback
approved these changes
May 27, 2020
|
thanks @mgmarino |
|
btw I think we should a mention of using isocalendar in the docs proper, maybe around here: https://pandas.pydata.org/pandas-docs/stable/user_guide/timeseries.html#time-date-components if you can do a PR would be great. |
|
I am very happy to expand the docs on this, but this is already a blurb on this right after this table: https://github.com/pandas-dev/pandas/blame/master/doc/source/user_guide/timeseries.rst#L789 |
|
ahh i c, yep forgot about that. lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup on #33595, (specifically here and here), where it was noted that
DatetimeIndex.isocalendarshould set the index of thereturned dataframe.