Skip to content

CI testing for s3 reads from public buckets on 1.0.x - DO NOT MERGE #34793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

CI testing for s3 reads from public buckets on 1.0.x - DO NOT MERGE #34793

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffe07f8
CI testing for s3 reads from public buckets on 1.0.x - DO NOT MERGE
simonjayhawkins Jun 15, 2020
c7be2cd
failing test
simonjayhawkins Jun 15, 2020
b09de22
Revert "failing test"
simonjayhawkins Jun 15, 2020
62bc278
Merge remote-tracking branch 'upstream/1.0.x' into test-for-34626
simonjayhawkins Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pandas/tests/io/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import pytest

import pandas.util._test_decorators as td

from pandas import read_csv

from pandas.io.common import is_s3_url
Expand All @@ -23,3 +25,10 @@ def test_streaming_s3_objects():
for el in data:
body = StreamingBody(BytesIO(el), content_length=len(el))
read_csv(body)


@td.skip_if_no("s3fs")
def test_read_csv_from_public_bucket():
# https://github.com/pandas-dev/pandas/issues/34626
result = read_csv("s3://nyc-tlc/misc/taxi _zone_lookup.csv")
assert result.shape == (265, 4)