Fix cython3 #35675
Fix cython3 #35675
Conversation
This reverts commit d3343d9.
Support for the new functions was exposed in cython 0.29.21
|
Should this take over from #34997? |
|
Ah, I missed #34997. I probably should pick off the second commit into its own PR and then sort out if my attempt here is the right path or the one in the other PR. That said, my guess is that this code is performance critical and was written the way it was as an optimization and I really don't have more than a passing understanding of the block manager so I am not the right person (and don't really have the bandwidth right now to become the right person) to take this on... |
|
|
||
| if isinstance(val, str): | ||
| l = PyUnicode_GET_SIZE(val) | ||
| l = PyUnicode_GET_LENGTH(val) |
There was a problem hiding this comment.
this can be done independently of the rest of the PR?
There was a problem hiding this comment.
Yeah, do you want to split it out?
|
Sorry for both the low-quality PR and dropping the ball on moving this forward. I had this sitting on my machine for a while, thought it was better to get it out in the public at all and that I would have more bandwidth to follow up :(. |
|
All good @tacaswell ! I think this is getting covered in some other PRs so closing this one to clear the queue, but effort much appreciated in any case |
3 participants
I'm not sure if this actually works, but it gets cython to compile with py310.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff