Skip to content

BLD/CI: fix py39 ci #36296 #36393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 16, 2020
Merged

BLD/CI: fix py39 ci #36296 #36393

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c774f3d
BLD/CI: fix py39 ci #36296
fangchenli Sep 16, 2020
3c4633e
BLD/CI fix deprecated unicode lenght check #36296
fangchenli Sep 16, 2020
95e0594
BLD/CI add py39 compat check
fangchenli Sep 16, 2020
0ee3216
BLD/CI bump cython version
fangchenli Sep 16, 2020
e0f4ee1
BLD/CI clean import
fangchenli Sep 16, 2020
9bf1a55
BLD/CI bump cython version, add doc
fangchenli Sep 16, 2020
6c13d7c
BLD/CI update install.rst
fangchenli Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ matrix:
- arch: arm64
env:
- JOB="3.7, arm64" PYTEST_WORKERS=8 ENV_FILE="ci/deps/travis-37-arm64.yaml" PATTERN="(not slow and not network and not clipboard)"
- dist: bionic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we have removed this @VirosaLi did we move 3.9 build to Azure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we have removed this @VirosaLi did we move 3.9 build to Azure?

It was removed from allow_failures.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh thanks misread the diff

env:
- JOB="3.9-dev" PATTERN="(not slow and not network and not clipboard)"


before_install:
Expand Down
3 changes: 1 addition & 2 deletions ci/build39.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@

sudo apt-get install build-essential gcc xvfb
pip install --no-deps -U pip wheel setuptools
pip install numpy python-dateutil pytz pytest pytest-xdist hypothesis
pip install cython --pre # https://github.com/cython/cython/issues/3395
pip install cython numpy python-dateutil pytz pytest pytest-xdist hypothesis

python setup.py build_ext -inplace
python -m pip install --no-build-isolation -e .
Expand Down
4 changes: 2 additions & 2 deletions pandas/_libs/writers.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import cython
from cython import Py_ssize_t

from cpython.bytes cimport PyBytes_GET_SIZE
from cpython.unicode cimport PyUnicode_GET_SIZE
from cpython.unicode cimport PyUnicode_GET_LENGTH

import numpy as np

Expand Down Expand Up @@ -144,7 +144,7 @@ cpdef inline Py_ssize_t word_len(object val):
Py_ssize_t l = 0

if isinstance(val, str):
l = PyUnicode_GET_SIZE(val)
l = PyUnicode_GET_LENGTH(val)
elif isinstance(val, bytes):
l = PyBytes_GET_SIZE(val)

Expand Down