TST: Fix assert_almost_equal error message #3737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you hook up travis? (I know this is a trivial PR, but for the future) |
|
I set it up...hadn't realized I needed to enable it in travis-ci. Do you want me to redo this commit to trigger it? |
|
sure |
Most tests are of form assert_almost_equal(result, expected). Verbose error message was treating its first argument as expected, this is now fixed.
|
got it - thanks! |
|
@wesm this looks fine for 0.11 |
jreback
added a commit
that referenced
this pull request
Jun 3, 2013
TST: Fix assert_almost_equal error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most tests (in pandas' test suite and in general) are of form
assert_almost_equal(result, expected). Verbose error message wastreating its first argument as expected, this is now fixed.
Previous message was:
But a, the first argument, is actually
actual, not expected.Everywhere else, it makes sense to display
"%s != %s" % (a,b)