CI: clean azure pipeline #38636
Closed
CI: clean azure pipeline #38636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 22, 2020 11:26
added 16 commits
December 22, 2020 12:21
fangchenli
commented
Dec 23, 2020
jreback
reviewed
Dec 23, 2020
| - bash: echo '##vso[task.prependpath]$(HOME)/miniconda3/bin' | ||
| displayName: 'Add conda to PATH' | ||
|
|
||
| - script: ci/setup_env.sh |
There was a problem hiding this comment.
so this is basically inlining setup_env?
There was a problem hiding this comment.
why are we doing this? that is called by every build
There was a problem hiding this comment.
We save about 2-3 min build time by using the CI's conda. And the Windows builds are not using the script. We probably could combine all Azure CI setups into one file. Now we have one for posix and one for windows. They are almost identical.
There was a problem hiding this comment.
ok the problem is there are other things that setup_env is doing which this is not. not averse to this, but we need to do it inside setup_env.sh
| parameters: | ||
| name: macOS | ||
| vmImage: macOS-10.14 | ||
| vmImage: macOS-10.15 |
There was a problem hiding this comment.
@fangchenli can any of this be split off into an easy preliminary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We save about 2-3 min build time by using Azure's conda.