Skip to content

DEPR: Hide deprecated attrs _AXIS_NAMES & _AXIS_NUMBERS #38740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 28, 2020
Merged

DEPR: Hide deprecated attrs _AXIS_NAMES & _AXIS_NUMBERS #38740

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa8fded
DEPR: Hide deprecated attrs _AXIS_NAMES & _AXIS_NUMBERS
topper-123 Dec 28, 2020
1f25122
fix test
topper-123 Dec 28, 2020
fdfafdb
make test for inspect.getmembers separate
topper-123 Dec 28, 2020
d2d88af
move skip_if_no
topper-123 Dec 28, 2020
6a78bc9
update
topper-123 Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,9 @@ class NDFrame(PandasObject, SelectionMixin, indexing.IndexingMixin):
]
_internal_names_set: Set[str] = set(_internal_names)
_accessors: Set[str] = set()
_hidden_attrs: FrozenSet[str] = frozenset(["get_values", "tshift"])
_hidden_attrs: FrozenSet[str] = frozenset(
["_AXIS_NAMES", "_AXIS_NUMBERS", "get_values", "tshift"]
)
_metadata: List[str] = []
_is_copy = None
_mgr: BlockManager
Expand Down
6 changes: 2 additions & 4 deletions pandas/tests/frame/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,12 +337,10 @@ def test_constructor_expanddim_lookup(self):
df = DataFrame()

with warnings.catch_warnings(record=True) as wrn:
# _AXIS_NUMBERS, _AXIS_NAMES lookups
inspect.getmembers(df)

# some versions give FutureWarning, others DeprecationWarning
assert len(wrn)
assert any(x.category in [FutureWarning, DeprecationWarning] for x in wrn)
# some versions may give FutureWarning, others DeprecationWarning
assert not len(wrn)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like unrelated to the actual test for constructor_expanddim. Maybe split it in two separate tests?


with pytest.raises(NotImplementedError, match="Not supported for DataFrames!"):
df._constructor_expanddim(np.arange(27).reshape(3, 3, 3))