Skip to content

BLD: fix build failure py3.9.1 on OSX #38766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 29, 2020
Merged

BLD: fix build failure py3.9.1 on OSX #38766

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2eb7052
BLD: fix build failure py3.9.1 on OSX
jbrockmendel Dec 28, 2020
0e5f1ab
Merge branch 'master' of https://github.com/pandas-dev/pandas into bl…
jbrockmendel Dec 29, 2020
a13b19b
whatsnew
jbrockmendel Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ def run(self):
"MACOSX_DEPLOYMENT_TARGET", current_system
)
if (
LooseVersion(python_target) < "10.9"
LooseVersion(str(python_target)) < "10.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if https://docs.python.org/3/library/sysconfig.html#module-sysconfig returns a bytestring (e.g. get_config_vars())

weird

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int 11

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm that's also weird

and LooseVersion(current_system) >= "10.9"
):
os.environ["MACOSX_DEPLOYMENT_TARGET"] = "10.9"
Expand Down