REGR: Rolling.count setting min_periods after call

doc/source/whatsnew/v1.2.2.rst

@@ -21,6 +21,7 @@ Fixed regressions
 - Fixed regression in :meth:`~DataFrame.to_pickle` failing to create bz2/xz compressed pickle files with ``protocol=5`` (:issue:`39002`)
 - Fixed regression in :func:`pandas.testing.assert_series_equal` and :func:`pandas.testing.assert_frame_equal` always raising ``AssertionError`` when comparing extension dtypes (:issue:`39410`)
 - Fixed regression in :meth:`~DataFrame.to_csv` opening ``codecs.StreamWriter`` in binary mode instead of in text mode and ignoring user-provided ``mode`` (:issue:`39247`)
+- Fixed regression in :meth:`core.window.rolling.Rolling.count` where the ``min_periods`` argument would be set to ``0`` after the operation (:issue:`39554`)
 -
 
 .. ---------------------------------------------------------------------------

pandas/core/window/rolling.py

@@ -1437,7 +1437,11 @@ def count(self):
                 FutureWarning,
             )
             self.min_periods = 0
-        return super().count()
+            result = super().count()
+            self.min_periods = None
+        else:
+            result = super().count()
+        return result
 
     @doc(
         template_header,

pandas/tests/window/test_api.py

@@ -325,3 +325,17 @@ def test_is_datetimelike_deprecated():
     s = Series(range(1)).rolling(1)
     with tm.assert_produces_warning(FutureWarning):
         assert not s.is_datetimelike
+
+
+@pytest.mark.filterwarnings("ignore:min_periods:FutureWarning")
+def test_dont_modify_attributes_after_methods(
+    arithmetic_win_operators, closed, center, min_periods
+):
+    # GH 39554
+    roll_obj = Series(range(1)).rolling(
+        1, center=center, closed=closed, min_periods=min_periods
+    )
+    expected = {attr: getattr(roll_obj, attr) for attr in roll_obj._attributes}
+    getattr(roll_obj, arithmetic_win_operators)()
+    result = {attr: getattr(roll_obj, attr) for attr in roll_obj._attributes}
+    assert result == expected

pandas/tests/window/test_base_indexer.py

@@ -159,7 +159,10 @@ def test_rolling_forward_window(constructor, func, np_func, expected, np_kwargs)
 
     # Check that the function output matches applying an alternative function
     # if min_periods isn't specified
-    rolling3 = constructor(values).rolling(window=indexer)
+    # GH 39604: After count-min_periods deprecation, apply(lambda x: len(x))
+    # is equivalent to count after setting min_periods=0
+    min_periods = 0 if func == "count" else None
+    rolling3 = constructor(values).rolling(window=indexer, min_periods=min_periods)
     result3 = getattr(rolling3, func)()
     expected3 = constructor(rolling3.apply(lambda x: np_func(x, **np_kwargs)))
     tm.assert_equal(result3, expected3)