Skip to content

DOC: update link to user guide #39869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2021
Merged

DOC: update link to user guide #39869

merged 3 commits into from
Feb 17, 2021

Conversation

morrme
Copy link
Contributor

@morrme morrme commented Feb 17, 2021

@pep8speaks
Copy link

pep8speaks commented Feb 17, 2021 •
edited
Loading

Hello @morrme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-17 19:18:12 UTC

@morrme morrme changed the title update link to user guide DOC: update link to user guide Feb 17, 2021
@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Feb 17, 2021
@MarcoGorelli
Copy link
Member

Built this locally and the link now works fine - thanks @morrme !

@MarcoGorelli MarcoGorelli merged commit 9313631 into pandas-dev:master Feb 17, 2021
@morrme morrme deleted the issue-39863 branch February 18, 2021 08:44
@MarcoGorelli MarcoGorelli mentioned this pull request Feb 18, 2021
Closed
@MarcoGorelli
Copy link
Member

@jorisvandenbossche I put the 1.3 milestone, but now I'm seeing other doc changes (e.g. #39858) being backported - should I change to 1.2.3 and backport?

@MarcoGorelli
Copy link
Member

This fixes a doc change concerning a 1.2 deprecation, so am pretty convinced it needs backporting

@meeseeksdev backport to 1.2.x

@meeseeksmachine meeseeksmachine mentioned this pull request Feb 18, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 18, 2021
@morrme @meeseeksmachine
Backport PR pandas-dev#39869: DOC: update link to user guide
bf3c009
@MarcoGorelli MarcoGorelli modified the milestones: 1.3, 1.2.3 Feb 18, 2021
@jreback
Copy link
Contributor

jreback commented Feb 18, 2021

normally we don't backport too much except for CI issues that are likely to affect 1.2.x
ok here if fixing something broken

simonjayhawkins pushed a commit that referenced this pull request Feb 18, 2021
@meeseeksmachine @morrme
Backport PR #39869: DOC: update link to user guide (#39883)
6c14bc6 
Co-authored-by: morrme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

1.2.3

Development

Successfully merging this pull request may close these issues.

DOC: fixup link for lookup example

4 participants

@morrme @pep8speaks @MarcoGorelli @jreback