Skip to content

Conversation

rhshadrach
Copy link
Member

  • Ensure all linting tests pass, see here for how to run them

Fixes CI for Windows 3.7 np1.6; regression in scipy 1.6.1 (scipy/scipy#13585)

Alternative would be to pin build, wasn't sure which is prefered over the other. Will open tracking issue once the method is decided.

@rhshadrach rhshadrach added Testing pandas testing functions or related to the test suite CI Continuous Integration Dependencies Required and optional dependencies labels Feb 24, 2021
sp_array = scipy.sparse.coo_matrix((data, (row, col)))
# TODO: Remove dtype when scipy is fixed
# https://github.com/scipy/scipy/issues/13585
sp_array = scipy.sparse.coo_matrix((data, (row, col)), dtype="int64")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe pass intp here?

@jreback jreback added this to the 1.2.3 milestone Feb 24, 2021
@jreback
Copy link
Contributor

jreback commented Feb 24, 2021

going to backport as well, ping on green.

@rhshadrach
Copy link
Member Author

rhshadrach commented Feb 24, 2021

Windows 3.7 np1.6 was successful, failures look unrelated. Running again.

@rhshadrach
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@rhshadrach
Copy link
Member Author

@jreback - greenish

Failing test is TestTimedeltas.test_to_timedelta_oob_non_nano, I'm seeing this fail on the most recent commit to master as well.

@jreback
Copy link
Contributor

jreback commented Feb 24, 2021

@jreback - greenish

Failing test is TestTimedeltas.test_to_timedelta_oob_non_nano, I'm seeing this fail on the most recent commit to master as well.

oh that's prob something we just merged cc @jbrockmendel

@jreback jreback merged commit 316f5ac into pandas-dev:master Feb 24, 2021
@jreback
Copy link
Contributor

jreback commented Feb 24, 2021

thanks @rhshadrach

@jreback
Copy link
Contributor

jreback commented Feb 24, 2021

@meeseeksdev backport 1.2.x

@jbrockmendel
Copy link
Member

test_to_timedelta_oob_non_nano

will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration Dependencies Required and optional dependencies Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants