Skip to content

DEPS: sync fastparquet version #40424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 15, 2021
Merged

DEPS: sync fastparquet version #40424

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6f6f21a
DEPS: sync fastparquet version
fangchenli Mar 14, 2021
eb35c56
Merge remote-tracking branch 'upstream/master' into sync-fastparquet-…
fangchenli Mar 14, 2021
54fbbd0
update version in test
fangchenli Mar 14, 2021
462e404
remove min version
fangchenli Mar 15, 2021
edf67bd
Merge remote-tracking branch 'upstream/master' into sync-fastparquet-…
fangchenli Mar 15, 2021
1efe2ce
black
fangchenli Mar 15, 2021
22e0dc8
Merge remote-tracking branch 'upstream/master' into sync-fastparquet-…
fangchenli Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.3.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ Optional libraries below the lowest tested version may still work, but are not c
+=================+=================+=========+
| beautifulsoup4 | 4.6.0 | |
+-----------------+-----------------+---------+
| fastparquet | 0.3.2 | |
| fastparquet | 0.4.0 | X |
+-----------------+-----------------+---------+
| fsspec | 0.7.4 | |
+-----------------+-----------------+---------+
Expand Down
2 changes: 1 addition & 1 deletion pandas/compat/_optional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"bs4": "4.6.0",
"bottleneck": "1.2.1",
"fsspec": "0.7.4",
"fastparquet": "0.3.2",
"fastparquet": "0.4.0",
"gcsfs": "0.6.0",
"lxml.etree": "4.3.0",
"matplotlib": "2.2.3",
Expand Down
6 changes: 5 additions & 1 deletion pandas/tests/io/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,11 @@ def test_filter_row_groups(self, pa):


class TestParquetFastParquet(Base):
@td.skip_if_no("fastparquet", min_version="0.3.2")
from pandas.compat._optional import VERSIONS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this at all, just remove the min version, no?


fp_min_ver = VERSIONS.get("fastparquet")

@td.skip_if_no("fastparquet", min_version=fp_min_ver)
def test_basic(self, fp, df_full):
df = df_full

Expand Down