PERF: fix regression in reductions for boolean/integer data (assume no missing values) #41920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o missing values)
jorisvandenbossche
added
Performance
This was referenced Jun 10, 2021
Closed
simonjayhawkins
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Thanks @jorisvandenbossche I perhaps should have done this originally for the regression fix in 1.2.4 #40143 (comment), but was hesitant to change lower level code.
|
Ah, indeed you noticed the issue back then as well. Yeah, I think this is not lower level than the later PR #41711 (which was also backported), and IMO this should be safe for a backport. |
|
@jorisvandenbossche I didn't notice #41911 (was on the wrong milestone) with a different fix. |
Merged
|
merged #41911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address performance regression in https://github.com/pandas-dev/pandas/pull/41711/files#r647515492 (https://pandas.pydata.org/speed/pandas/#series_methods.All.time_all?python=3.8&Cython=0.29.21&p-N=1000000&p-case='fast'&p-dtype='bool'&commits=9231b495-44237a58)