Skip to content

BUG: OutOfBoundsTimedelta not raised for out-of-bounds Timedelta #42235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2021
Merged

BUG: OutOfBoundsTimedelta not raised for out-of-bounds Timedelta #42235

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7bbe4a5
BUG: added test #36615
Jun 25, 2021
9797e43
moved and parametrized test
Jun 26, 2021
ba3739a
Merge branch 'pandas-dev:master' into oob-tdelta
feefladder Jul 10, 2021
6257b71
Merge branch 'pandas-dev:master' into oob-tdelta
feefladder Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/tests/tslibs/test_timedeltas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
offsets,
)

from pandas.errors import OutOfBoundsTimedelta


@pytest.mark.parametrize(
"obj,expected",
Expand Down Expand Up @@ -37,3 +39,9 @@ def test_huge_nanoseconds_overflow():
# GH 32402
assert delta_to_nanoseconds(Timedelta(1e10)) == 1e10
assert delta_to_nanoseconds(Timedelta(nanoseconds=1e10)) == 1e10


def test_out_of_bounds():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should go in pandas.tests.scalar.timedelta.test_constructors

# GH 36615
with pytest.raises(OutOfBoundsTimedelta, match="200000 days"):
Timedelta(np.timedelta64(200000, "D"))