Skip to content

Updated the return type section of to_datetime #42244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 11, 2021
Merged

Updated the return type section of to_datetime #42244

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6166986
Updated the return type section of to_datetime to include list-like m…
prabha-git Jun 25, 2021
cb4dbd1
updated the Returns section
prabha-git Jun 26, 2021
dfa298a
updated the Return section as suggested by mroeschke
prabha-git Jun 27, 2021
c35571d
Merge branch 'pandas-dev:master' into to_datetime_returns
prabha-git Jun 27, 2021
d84f2c7
removed the extra line in my previous commit
prabha-git Jun 27, 2021
f131e7b
Merge branch 'to_datetime_returns' of https://github.com/prabha-git/p…
prabha-git Jun 27, 2021
6efbb73
Update pandas/core/tools/datetimes.py
prabha-git Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pandas/core/tools/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,10 +762,13 @@ def to_datetime(
If parsing succeeded.
Return type depends on input:

- list-like: DatetimeIndex
- list-like:
- DatetimeIndex, if timezone naive or aware with the same timezone
Copy link
Contributor

@smarie smarie Jun 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #42229 (comment)

Suggested change
- DatetimeIndex, if timezone naive or aware with the same timezone
- DatetimeIndex, if timezone naive or aware with the same time offset

- Index of object dtype, if timezone aware with mixed timezones
- Series: Series of datetime64 dtype
- scalar: Timestamp


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could you remove this newline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can

In case when it is not possible to return designated types (e.g. when
any element of input is before Timestamp.min or after Timestamp.max)
return will have datetime.datetime type (or corresponding
Expand Down