Skip to content

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Jul 13, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Thanks realead for fixing the tests.

@lithomas1 lithomas1 marked this pull request as ready for review July 13, 2021 22:21
@lithomas1 lithomas1 added CI Continuous Integration Python 3.10 Testing pandas testing functions or related to the test suite labels Jul 13, 2021
@lithomas1 lithomas1 added this to the 1.3.1 milestone Jul 13, 2021
@jreback
Copy link
Contributor

jreback commented Jul 13, 2021

this ok to backport? these were related to @realead patches that we did backport?

@lithomas1
Copy link
Contributor Author

Yep should be #42135 and #41988 iirc.

@jreback jreback merged commit 0d393d7 into pandas-dev:master Jul 13, 2021
@jreback
Copy link
Contributor

jreback commented Jul 13, 2021

great thanks @lithomas1

@jreback
Copy link
Contributor

jreback commented Jul 13, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jul 13, 2021

Something went wrong ... Please have a look at my logs.

@lithomas1 lithomas1 deleted the xfail-less branch July 14, 2021 00:32
simonjayhawkins added a commit that referenced this pull request Jul 14, 2021
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration Python 3.10 Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants