Skip to content

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #42539: Revert "CI: runtime warning in npdev build"

@lumberbot-app lumberbot-app bot added this to the 1.3.1 milestone Jul 14, 2021
@lumberbot-app lumberbot-app bot added the CI Continuous Integration label Jul 14, 2021
@lithomas1
Copy link
Contributor

lithomas1 commented Jul 15, 2021

Hmm. This actually xpasses on 3.8 npdev as well in addition to Python 3.9, hence the CI failure. Maybe the solution is to just remove the xfail altogether. Unfortunately, without #42538 backported, we won't know, since master has no 3.8 np dev job anymore.

I think we should wait on this one for a while. If a better solution comes up, we can always close this and backport that one.

@jreback
Copy link
Contributor

jreback commented Jul 15, 2021

Hmm. This actually xpasses on 3.8 npdev as well in addition to Python 3.9, hence the CI failure. Maybe the solution is to just remove the xfail altogether. Unfortunately, without #42538 backported, we won't know, since master has no 3.8 np dev job anymore.

I think we should wait on this one for a while. If a better solution comes up, we can always close this and backport that one.

you can also do a PR against the 1.3.x branch directly and see

@lithomas1
Copy link
Contributor

OK, this seems to also xpass on 3.8 npdev(1.3.x branch). I'll try to send in a PR soonish.

@lithomas1 lithomas1 closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants