Revert "PERF: tighten _should_compare for MultiIndex" #42575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 381dd06.
jbrockmendel
added
the
Regression
|
@simonjayhawkins @jreback should we try to get this in for 1.3.1? |
|
#42231 (source of regression) is not on 1.3.x? |
|
woops, assumed bc we got a bug report it must have been released, but not so |
4 tasks
|
thanks @jbrockmendel |
CGe0516
pushed a commit
to CGe0516/pandas
that referenced
this pull request
Jul 29, 2021
…" (pandas-dev#42575) This reverts commit 381dd06.
2 tasks
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
…" (pandas-dev#42575) This reverts commit 381dd06.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #42231
This introduced a bug discussed in #42231. The long-term fix is in MultiIndex.get_indexer, but that's going to take me a little while to get done.