Skip to content

REGR: sample modifying weights inplace #42843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2021
Merged

REGR: sample modifying weights inplace #42843

merged 3 commits into from
Aug 4, 2021

Conversation

mzeitlin11
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Targeting 1.4 and no whatsnew since only a regression on master.

@mzeitlin11 mzeitlin11 added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Regression Functionality that used to work in a prior pandas version labels Aug 1, 2021
@mzeitlin11 mzeitlin11 added this to the 1.4 milestone Aug 1, 2021
jbrockmendel
jbrockmendel approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KrishnaSai2020
KrishnaSai2020 approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@KrishnaSai2020 KrishnaSai2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be fine.

@jreback
Copy link
Contributor

jreback commented Aug 4, 2021

looks fine can you add a whatsnew note (1.4) reshaping is fine & ping on green.

@mzeitlin11
Copy link
Member Author

looks fine can you add a whatsnew note (1.4) reshaping is fine & ping on green.

Didn't include a whatsnew because it is only a regression on master caused by #42233

@jreback
Copy link
Contributor

jreback commented Aug 4, 2021

looks fine can you add a whatsnew note (1.4) reshaping is fine & ping on green.

Didn't include a whatsnew because it is only a regression on master caused by #42233

kk cool

@jreback jreback merged commit 2d9ca9d into pandas-dev:master Aug 4, 2021
@jreback
Copy link
Contributor

jreback commented Aug 4, 2021

thanks @mzeitlin11

@mzeitlin11 mzeitlin11 deleted the regr_sample_weights_modify branch August 4, 2021 22:42
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@mzeitlin11 @feefladder
REGR: sample modifying weights inplace (pandas-dev#42843)
f50d447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

+1 more reviewer

@KrishnaSai2020 KrishnaSai2020 KrishnaSai2020 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Regression Functionality that used to work in a prior pandas version

Projects

None yet

Milestone

1.4

Development

Successfully merging this pull request may close these issues.

4 participants

@mzeitlin11 @jreback @jbrockmendel @KrishnaSai2020