Skip to content

BUG: Boxplot to return axes, not dict #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

BUG: Boxplot to return axes, not dict #4472

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acb1af3
BUG: switched boxplot to return axes, not boxplot dict
phobson Aug 5, 2013
6311071
TST: cleaned up general test functions to ensure everything returns a…
phobson Aug 29, 2013
0a7feee
RVT: fixing valid plot obj test
phobson Aug 29, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pandas/tests/test_graphics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,8 +565,7 @@ def test_boxplot(self):

_check_plot_works(df.boxplot)
_check_plot_works(df.boxplot, column=['one', 'two'])
_check_plot_works(df.boxplot, column=['one', 'two'],
by='indic')
_check_plot_works(df.boxplot, column=['one', 'two'], by='indic')
_check_plot_works(df.boxplot, column='one', by=['indic', 'indic2'])
_check_plot_works(df.boxplot, by='indic')
_check_plot_works(df.boxplot, by=['indic', 'indic2'])
Expand Down Expand Up @@ -1068,7 +1067,7 @@ def assert_is_valid_plot_return_object(objs):
'type encountered {0!r}'
''.format(el.__class__.__name__))
else:
assert isinstance(objs, (plt.Artist, tuple, dict)), \
assert isinstance(objs, plt.Axes), \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phobson This should be kept as plt.Artist since not all plotting functions return Axes instances.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phobson Can you remove the dict check here, since boxplot was the only function returning a dict?

('objs is neither an ndarray of Artist instances nor a '
'single Artist instance, tuple, or dict, "objs" is a {0!r} '
''.format(objs.__class__.__name__))
Expand Down
4 changes: 1 addition & 3 deletions pandas/tools/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1839,10 +1839,8 @@ def plot_group(grouped, ax):
ax.set_yticklabels(keys, rotation=rot, fontsize=fontsize)
ax.grid(grid)

ret = bp

fig.subplots_adjust(bottom=0.15, top=0.9, left=0.1, right=0.9, wspace=0.2)
return ret
return ax


def format_date_labels(ax, rot):
Expand Down