Skip to content

Conversation

aliraeisdanaei
Copy link

@aliraeisdanaei aliraeisdanaei commented Dec 26, 2021

@pep8speaks
Copy link

pep8speaks commented Dec 26, 2021

Hello @aliraeisdanaei! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-10 15:17:01 UTC

@aliraeisdanaei
Copy link
Author

Hey, this is my first pull request to pandas, so please do tell me if I have made any mistakes.

Thank you & God bless,
Ali Raeisdanaei

@aliraeisdanaei
Copy link
Author

@jbrockmendel Thanks for the feedback.

@jreback jreback added this to the 1.4 milestone Dec 27, 2021
@jreback jreback added Groupby Testing pandas testing functions or related to the test suite labels Dec 27, 2021
@jreback jreback changed the title Adding a test case for the issue 28570 Groupby Agg not working if different partials with same name on the same column Dec 28, 2021
@jreback jreback removed this from the 1.4 milestone Dec 29, 2021
@mroeschke mroeschke added this to the 1.5 milestone Jan 10, 2022
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this closes the issue, see #28570 (comment) for details.

@mroeschke
Copy link
Member

Thanks for the PR, but it appears to have gone stale. If you'd like to continue and investigate the bug fix, please ping and we can reopen.

@mroeschke mroeschke closed this Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Groupby Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Groupby Agg not working if different partials with same name on the same column

6 participants